Skip to content

Squash CI Bugs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Squash CI Bugs #7

merged 3 commits into from
Jan 6, 2020

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Jan 6, 2020

closes #6

The purpose of this PR is to squash bugs which are preventing the master branch from passing CI.

This involves:

  • adding chopper.ply and 2085.csv data files to the repo filesystem instead of making API calls at build time

  • adding random package to DESCRIPTION

CI build steps renamed for clarity.

download chopper.ply to repo

add 2805.csv to repo

Remove curl

move files to data folder

adding random package
@jdamiba jdamiba mentioned this pull request Jan 6, 2020
@@ -343,8 +343,8 @@ library(plotly)
# Sys.setenv('MAPBOX_TOKEN' = 'your mapbox token')

# read in wind turbines and farms data
df_wind = read.csv('https://plot.ly/~datasets/2805.csv')
df_farms = read.csv('https://plot.ly/~jackp/17256.csv')
df_wind = read.csv('data/2805.csv')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why must we in-line this one and not the next one? Seems odd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of the command df_wind = read.csv('https://plot.ly/~datasets/2805.csv') is:

df_wind = read.csv('https://plot.ly/~datasets/2805.csv')

 *** caught segfault ***
address 0x10b966000, cause 'memory not mapped'

Traceback:
 1: scan(file = file, what = what, sep = sep, quote = quote, dec = dec,     nmax = nrows, skip = 0, na.strings = na.strings, quiet = TRUE,     fill = fill, strip.white = strip.white, blank.lines.skip = blank.lines.skip,     multi.line = FALSE, comment.char = comment.char, allowEscapes = allowEscapes,     flush = flush, encoding = encoding, skipNul = skipNul)
 2: read.table(file = file, header = header, sep = sep, quote = quote,     dec = dec, fill = fill, comment.char = comment.char, ...)
 3: read.csv("https://plot.ly/~datasets/2805.csv")

Inlining solves the error, which does not appear for df_farms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird

download.file(plyFile, dest)
}

dest <- "data/chopper.ply"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this must be inlined and no other files? Just the download.file command doesn’t work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m fine with inlining, just curious about when we must vs can just continue as was

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to access the file at the URL, the following error is thrown:

trying URL 'http://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply'
Quitting from lines 73-106 (2016-06-17-3d-tri-surf.Rmd) 
Error in download.file(plyFile, dest) : 
  cannot open URL 'http://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply'
Calls: <Anonymous> ... withCallingHandlers -> withVisible -> eval -> eval -> download.file
In addition: Warning messages:
1: In rgl.init(initValue, onlyNULL) : RGL: unable to open X11 display
2: 'rgl_init' failed, running with rgl.useNULL = TRUE 
3: In download.file(plyFile, dest) :
  URL 'https://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply': status was 'SSL connect error'

I believe SSL is set up correctly in the container, as libcurl4-openssl-dev and ca-certificates are both installed. Seems like an issue with the server?

@nicolaskruchten
Copy link
Contributor

💃

@jdamiba jdamiba merged commit f89a052 into master Jan 6, 2020
@jdamiba jdamiba deleted the fix-ci branch January 6, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI has SSL issues
2 participants